Newbie: Validation errors

[Dimerx]

I am getting very aggravated try to validate an authorised user, however I am not getting any errors but its not giving the correct response when either you have entered the correct user details or not. The varible of $nrows stays at "0"

Orginally the first part of the sql statement request worked (varible $nrows = "1") when I tried a verified a user before adding the user to the table now with this php statement it doesn't! What am I doing wrong?


// Check Username
include ("serverdtls.php");// Server Details
mysql_connect($host,$user,$spassword) or die(mysql_error());
mysql_select_db($database);
$sql = "SELECT userName FROM Auth_members WHERE userName = '$userName'";
$result = mysql_query($sql) or die(mysql_error());
$nrows = mysql_num_rows($result);
//echo "

$nrows</p>";
if (($nrows == "1" )|| ($nrows > "1")) {//Username Correct
mysql_connect($host,$user,$spassword) or die(mysql_error());
mysql_select_db($database);
$sql = "SELECT userName FROM Auth_members WHERE userName = '$userName' AND password = '$pwd'";
$result2 = mysql_query($sql) or die(mysql_error());
$nrows2 = mysql_num_rows($result2);
if (($nrows2 == "1" ) || ($nrows2 > "1")) {//Password Correct
//include (Memberlog.inc)
include( "http://www.mysite.com/xxx/....." );
exit();
}

else {
$msgno = "1";
include ("MemLogin.php" );
exit();
}
}
else if($nrows == "0") {
header ("Location: http://www.mysite/xxx2." );
exit;
}
?>

[gvwiberg]

Hi there!

if (($nrows2 == "1" ) || ($nrows2 > "1")) {//Password Correct
//code...

means THAT if $nrows ARE 1 OR LARGER THAN 1, then run code...

Is that what you want?

If this is the case you could type it like this:
Observe that I took away the " because you want to check numeric values...

if (($nrows2 >= 1 )) {
//code...
}


Another thing:

You have TWO controls of username and password, that doesn't seem neccesary...
You could only use the control where both username and password is checked like this:


mysql_connect($host,$user,$spassword) or die(mysql_error());
mysql_select_db($database);
$sql = "SELECT userName FROM Auth_members WHERE userName = '$userName' AND password = '$pwd'";

and your other code...

Hope this helps a bit...

/G
@varupiraten.se

[Dimerx]

Thank you for your assistance. I will amend my script , however, for some reason this may not resolve the problem I think I am having.